test(e2e,Fabric): add e2e tests for issue/PR examples 42..528#2787
Merged
test(e2e,Fabric): add e2e tests for issue/PR examples 42..528#2787
Conversation
kligarski
changed the title
kkafar
force-pushed
the
@kligarski/add-e2e-tests
branch
from
a7ed28a to
3db0128
Compare
kkafar
requested changes
Mar 28, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Thanks! This looks kinda good initially. I have left few important remarks down below, please answer them.
kkafar
changed the title
kkafar
approved these changes
Mar 31, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Good job. I think we're good enough now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check which example screens from issues/PRs can be used in e2e testing for tests
Test42, ..., Test528and implement them if possible for Fabric. In the future, each non-skipped test will be in a seperate PR.Test42
Skipped because we can’t really check what is the orientation of the screen with Detox.
Test111
Skipped because we can’t test flickering with Detox.
Test263
Skipped because example differs from the problem mentioned in #263. Even when I recreated the issue, it still occurs. This comment from the PR explains why it is the case.
Test349
Skipped because we can’t test autofill with Detox. The test also uses outdated prop name.
Test364
Skipped because the test uses
tabBarVisibleprop that no longer exists.react-navigationdocumentation suggests other solution to this problem.Test 432
Test created. It checks whether correct squares are fully visible. For some reason, on Android, these squares are not
100%visible from the start (but I don’t see the problem in manual testing). For the test,waitingForthe squares to become100%visible works.Test 528
Test created but only for iOS because Detox supports changing orientation of the device only on iOS. Test checks if the headerRight button is visible after changing screens/orientation.
Changes
Test432andTest528apps/src/tests/index.tswith the reason for (not) implementing e2e test for itTest code and steps to reproduce
CI
Checklist